Re: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH 0/4] x86: Support "-cpu feature=force"
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8ffc6d4 x86: Support feature=force on the command-line
9418a88 tests: Add [+-]feature and feature=on|off test cases
f6954a1 string-input-visitor: Support alternate types
ea7dc8d visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

=== OUTPUT BEGIN ===
Checking PATCH 1/4: visitor: Add 'supported_qtypes' parameter to 
visit_start_alternate()...
Checking PATCH 2/4: string-input-visitor: Support alternate types...
Checking PATCH 3/4: tests: Add [+-]feature and feature=on|off test cases...
ERROR: line over 90 characters
#59: FILE: tests/test-x86-cpuid-compat.c:104:
+static uint32_t get_feature_word(QList *features, uint32_t eax, uint32_t ecx, 
const char *reg)

WARNING: line over 80 characters
#65: FILE: tests/test-x86-cpuid-compat.c:110:
+        if (eax == qint_get_int(qobject_to_qint(qdict_get(w, 
"cpuid-input-eax")))

WARNING: line over 80 characters
#67: FILE: tests/test-x86-cpuid-compat.c:112:
+                || ecx == qint_get_int(qobject_to_qint(qdict_get(w, 
"cpuid-input-ecx"))))

ERROR: line over 90 characters
#68: FILE: tests/test-x86-cpuid-compat.c:113:
+            && !strcmp(qstring_get_str(qobject_to_qstring(qdict_get(w, 
"cpuid-register"))), reg)) {

WARNING: line over 80 characters
#86: FILE: tests/test-x86-cpuid-compat.c:131:
+    value = get_feature_word(present, args->input_eax, args->input_ecx, 
args->reg);

WARNING: line over 80 characters
#87: FILE: tests/test-x86-cpuid-compat.c:132:
+    value |= get_feature_word(filtered, args->input_eax, args->input_ecx, 
args->reg);

total: 2 errors, 4 warnings, 130 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: x86: Support feature=force on the command-line...
WARNING: line over 80 characters
#186: FILE: tests/test-x86-cpuid-compat.c:135:
+        value |= get_feature_word(filtered, args->input_eax, args->input_ecx, 
args->reg);

total: 0 errors, 1 warnings, 168 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden