[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag |
Date: |
Fri, 31 Mar 2017 21:46:24 -0300 |
virtio-mmio needs to be wired and mapped by other device or board
code, and won't work with -device. Remove the user_creatable flag
from the device class.
Cc: Peter Maydell <address@hidden>
Cc: Shannon Zhao <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/virtio/virtio-mmio.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index b595512a3d..5807aa87fe 100644
--- a/hw/virtio/virtio-mmio.c
+++ b/hw/virtio/virtio-mmio.c
@@ -450,11 +450,6 @@ static void virtio_mmio_class_init(ObjectClass *klass,
void *data)
dc->reset = virtio_mmio_reset;
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
dc->props = virtio_mmio_properties;
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo virtio_mmio_info = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag, (continued)
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 17/19] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 18/19] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag,
Eduardo Habkost <=