[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag |
Date: |
Fri, 31 Mar 2017 21:46:14 -0300 |
The kvmvapic device needs to be created by apic_common_realize()
when apic-common.vapic=on is set, not using -device. Remove the
user_creatable flag from the device class.
Cc: Igor Mammedov <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/i386/kvmvapic.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index fbada19253..82a49556af 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -856,11 +856,6 @@ static void vapic_class_init(ObjectClass *klass, void
*data)
dc->reset = vapic_reset;
dc->vmsd = &vmstate_vapic;
dc->realize = vapic_realize;
- /*
- * FIXME: Set only for compatibility on q35 machine-type.
- * Probably never meant to be user-creatable
- */
- dc->user_creatable = true;
}
static const TypeInfo vapic_type = {
--
2.11.0.259.g40922b1
- [Qemu-devel] [RFC 00/19] sysbus: Don't allow -device/device_add by default, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 02/19] s390: Add FIXME for unexplained user_creatable=false line, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 01/19] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 04/19] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 06/19] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 07/19] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 09/19] kvmvapic: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 12/19] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 13/19] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 11/19] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 14/19] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 15/19] esp: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 16/19] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 17/19] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 18/19] sysbus-ohci: Remove user_creatable flag, Eduardo Habkost, 2017/03/31
- [Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag, Eduardo Habkost, 2017/03/31