Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs

[Peter Maydell]

On 6 February 2017 at 11:29, Daniel P. Berrange <address@hidden> wrote:
> In
>
>   commit ba78db44f6532d66a1e704bd44613e841baa2fc5
>   Author: Daniel P. Berrange <address@hidden>
>   Date:   Wed Jan 25 16:14:10 2017 +0000
>
>   make: move top level dir to end of include search path
>
> The dir $(BUILD_DIR)/$(@D) was added to the include
> path. This would sometimes point to a non-existant
> directory, if the sub-dir in question did not contain
> any target-independant files (eg tcg/). To deal with
> this the rules.mak attempted to create the directory.
>
> While this was succesful, it also caused accidental
> creation of files in the parent of the build dir.
> e.g. when building common source files into target
> specific output files.
>
> Rather than trying to workaround this, just revert
> the code that attempted to mkdir the missing include
> directories. Instead just turn off the compiler warning
> in question as the missing dir is expected & harmless
> in general.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---

Thanks; planning to apply this to master as a buildfix with the
following added to the commit message:

    NB: you can clean up a build directory parent that has
    been filled with empty directories by commit ba78db44f653
    using this GNU find command in that parent directory:
      find audio backends block chardev crypto disas fsdev hw io linux-user \
        migration nbd net qapi qom replay slirp target ui util \
        -type d -empty -delete

thanks
-- PMM