qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] rules: don't try to create missing include dirs
Date: Mon, 6 Feb 2017 13:22:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1


On 06/02/2017 13:05, Daniel P. Berrange wrote:
>>>          $(shell mkdir -p ./ $(sort $(dir $($v))))
>>> -        $(shell cd $(BUILD_DIR) && mkdir -p ./ $(sort $(dir $($v))))
>> I know this is the same syntax as the existing line above
>> and we're deleting it anyway, but what does it actually do?
>> When does telling mkdir to create "./" make sense?
> No idea why the ./ was there originally - it appears to serve no
> purpose. The useful bit is the stuff afterwards - the $($v) bit.
> It gets populated based on the variable being unnested. For example
> 
>    block-obj-y = block.o blockjob.o block/ nbd/
> 
> will make $v contain  "block nbd", hence cause creation of those
> dirs in the the build dir.

"mkdir -p" with no arguments gives an error, the "./" shuts it up.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]