[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container |
Date: |
Mon, 6 Feb 2017 10:05:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 02/02/2017 15:51, Marc-André Lureau wrote:
> + if (QTAILQ_IN_USE(chr, next)) {
> + QTAILQ_REMOVE(&chardevs, chr, next);
> + }
> + if (OBJECT(chr)->parent) {
> + object_unparent(OBJECT(chr));
> + } else {
> + object_unref(OBJECT(chr));
> + }
What's the case where the "else" is used? Probably qemu_chr_delete
callers should be changed to use object_unparent or object_unref directly.
Paolo
- [Qemu-devel] [PATCH 00/22] chardev clean-ups & tests, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 01/22] char: remove qemu_chr_be_generic_open, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 03/22] xen: use a better chardev type check, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 02/22] mux: simplfy muxes_realize_done, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 04/22] container: don't leak container reference, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 05/22] main: free root container, Marc-André Lureau, 2017/02/02
- [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/02
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/07
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/09
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Marc-André Lureau, 2017/02/10
- Re: [Qemu-devel] [PATCH 06/22] char: add a /chardevs container, Paolo Bonzini, 2017/02/10
[Qemu-devel] [PATCH 07/22] char: use /chardevs container instead of chardevs list, Marc-André Lureau, 2017/02/02
[Qemu-devel] [PATCH 08/22] char: remove qemu_chardev_add, Marc-André Lureau, 2017/02/02
[Qemu-devel] [PATCH 09/22] char: remove chardevs list, Marc-André Lureau, 2017/02/02
[Qemu-devel] [PATCH 10/22] char: useless NULL check, Marc-André Lureau, 2017/02/02