Re: [Qemu-devel] [PATCH 05/22] main: free root container

[Paolo Bonzini]

On 02/02/2017 15:51, Marc-André Lureau wrote:
> This should eventually free all objects that are only referenced by
> their parents.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index 0b72b12878..945df1d17f 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4640,6 +4640,7 @@ int main(int argc, char **argv, char **envp)
>      audio_cleanup();
>      monitor_cleanup();
>      qemu_chr_cleanup();
> +    object_unref(object_get_root());

This seems dangerous.  I'm pretty sure that a lot of non-hot-unpluggable
devices would leak or crash.

Paolo