Re: [Qemu-devel] [PATCH 2/2] savevm: Add new helpers to process the different stages of loadvm/savevm

[Hailiang Zhang]

On 2017/1/31 18:19, Juan Quintela wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
> > * zhanghailiang (address@hidden) wrote:
> > > There are several stages during loadvm/savevm process. In different stage,
> > > migration incoming processes different types of sections.
> > > We want to control these stages more accuracy, it will benefit COLO
> > > performance, we don't have to save type of QEMU_VM_SECTION_START
> > > sections everytime while do checkpoint, besides, we want to separate
> > > the process of saving/loading memory and devices state.
> > >
> > > So we add three new helper functions: qemu_loadvm_state_begin(),
> > > qemu_load_device_state() and qemu_savevm_live_state() to achieve
> > > different process during migration.
> > >
> > > Signed-off-by: zhanghailiang <address@hidden>
> > > Signed-off-by: Li Zhijian <address@hidden>
> > > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> >
> > I don't think this one can go in without the patch that follows which
> > uses these functions; we don't normally add functions
> > without the patch that uses them.
>
> Agreed.  If you want to add functions, you need new code that use them,
> or make old code use them.  It is up to you.

Got it, thanks, I'll merge this series with the one where we use them.

> Thanks, Juan.
>
> .