[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation. |
Date: |
Fri, 3 Feb 2017 23:44:23 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 03/02/2017 11:22, Richard W.M. Jones wrote:
>
> I think that the --fork option is mainly intended for command line use
> of qemu-nbd. If you're running qemu-nbd from a program there's no
> real reason to use --fork, since you can control the fork process
> better yourself.
>
> LISTEN_PID isn't settable from the command line. It's also not
> settable from a shell script (as far as I can tell when I was trying
> to write a shell script to test nbdkit). It has to be set between the
> fork and exec calls, because it is set to the qemu-nbd PID.
>
> So I don't think --fork and socket activation are really features that
> it makes any sense to mix.
I agree it doesn't really make sense, but I also don't see why it
wouldn't work.
Paolo