Re: [Qemu-devel] [PATCH v3] qemu-nbd: Implement socket activation.

[Paolo Bonzini]

On 03/02/2017 09:09, Richard W.M. Jones wrote:
> +                                                   const char *port,
> +                                                   bool fork_process)
> +{
> +    if (device != NULL) {
> +        return "NBD device can't be set when using socket activation";
> +    }
> +
> +    if (sockpath != NULL) {
> +        return "Unix socket can't be set when using socket activation";
> +    }
> +
> +    if (address != NULL) {
> +        return "The interface can't be set when using socket activation";
> +    }
> +
> +    if (port != NULL) {
> +        return "TCP port number can't be set when using socket activation";
> +    }
> +
> +    if (fork_process) {
> +        return "Fork (--fork) can't be used with socket activation";
> +    }

Why not?  You could have a Type=forking foo.service, which makes little
sense but would work.

Apart from this, the patch seems fine.

> +    return NULL;
> +}