Re: [Qemu-devel] [PATCH 10/54] char: rename CharDriverState Chardev

[Eric Blake]

On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> Uniformify chardev type name.

"Uniformify" - cute :)  I might have written:

Pick a uniform chardev type name.

instead of inventing a word, but you're call on whether to keep it.

> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  81 files changed, 728 insertions(+), 725 deletions(-)

Big, but mostly mechanical.

> @@ -268,9 +268,9 @@ static int baum_deferred_init(BaumDriverState *baum)
>  }
>  
>  /* The serial port can receive more of our data */
> -static void baum_accept_input(struct CharDriverState *chr)
> +static void baum_accept_input(struct Chardev *chr)

Do we still need the 'struct' in this parameter list?  Separate cleanup
may be okay.

A grep on your github chrfe branch shows that it looks like you got them
all, so
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature