qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/54] bt: use qemu_chr_alloc()


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/54] bt: use qemu_chr_alloc()
Date: Wed, 4 Jan 2017 15:18:24 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 12/12/2016 04:42 PM, Marc-André Lureau wrote:
> Use common allocator for CharDriverState.
> 
> Rename the now untouched parent field.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/bt/hci-csr.c | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 

> 
>  static inline void csrhci_fifo_wake(struct csrhci_s *s)
>  {
> -    CharBackend *be = s->chr.be;
> +    CharDriverState *chr = (CharDriverState *)s;

Another one of those temporary casts that got me stuck on 8/54. So with
the same idea of the commit message mentioning that it gets better later
in the series,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]