[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] Crypto: fix leak in ivgen essiv init |
Date: |
Wed, 4 Jan 2017 10:25:40 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Jan 03, 2017 at 08:31:34PM -0800, Li Qiang wrote:
> From: Li Qiang <address@hidden>
>
> On error path, the 'salt' doesn't been freed thus leading
> a memory leak. This patch avoid this.
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
> crypto/ivgen-essiv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c
> index 634de63..cba20bd 100644
> --- a/crypto/ivgen-essiv.c
> +++ b/crypto/ivgen-essiv.c
> @@ -48,6 +48,7 @@ static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen,
> &salt, &nhash,
> errp) < 0) {
> g_free(essiv);
> + g_free(salt);
> return -1;
> }
Looks good, thanks, added to the crypto-next queue.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|