[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests |
Date: |
Wed, 7 Dec 2016 17:59:56 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Tue, Dec 06, 2016 at 12:05:23PM -0600, Wei Huang wrote:
> Changes from v13:
> * Rename cp15.h to sysreg.h for ARMv7 and add a new file sysreg.h for ARMv8
> * Add macros for read_sysreg() and write_sysreg(). CP15 registers can be
> defined with __ACCESS_CP15() or __ACCESS_CP15_64(). sysreg.h (ARMv8) was
> from Drew's GIC testing code, which can be leveraged when his GIC testing
> code is imported.
> * Rewrite PMU testing code based on new macros. All get_xxx() and set_xxx()
> functions are defined in pmu.c based on read_sysreg() and write_sysreg().
> So the code parsing tool, like cscope, can parse them easily.
> * Minor fixes inside pmu.c, printf formatting, pmu_probe() func, based on
> Andre's comments.
Thanks for this Wei. I like the sysreg framework. It should address
Andre's concerns with asm-maintainability, plus maintain code analysis
tool (cscope) support.
The series looks good to me, so I'll apply it to arm/next and rebase the
gic series on it, using the new sysreg framework everywhere needed.
drew
>
> Note:
> Current KVM code has bugs in handling PMCCFILTR write. A fix (see below) is
> required for this unit testing code to work correctly under KVM mode.
> Link:
> https://lists.cs.columbia.edu/pipermail/kvmarm/2016-November/022134.html.
>
> Thanks,
> -Wei
>
> Christopher Covington (3):
> arm: Add PMU test
> arm: pmu: Check cycle count increases
> arm: pmu: Add CPI checking
>
> Wei Huang (2):
> arm: rename cp15.h to sysreg.h
> arm: Add support for read_sysreg() and write_sysreg()
>
> arm/Makefile.common | 3 +-
> arm/cstart.S | 2 +-
> arm/pmu.c | 290
> +++++++++++++++++++++++++++++++++++++++
> arm/unittests.cfg | 19 +++
> lib/arm/asm/processor.h | 6 +-
> lib/arm/asm/{cp15.h => sysreg.h} | 25 +++-
> lib/arm64/asm/processor.h | 11 +-
> lib/arm64/asm/sysreg.h | 26 ++++
> lib/libcflat.h | 4 +-
> 9 files changed, 369 insertions(+), 17 deletions(-)
> create mode 100644 arm/pmu.c
> rename lib/arm/asm/{cp15.h => sysreg.h} (68%)
> create mode 100644 lib/arm64/asm/sysreg.h
>
> --
> 1.8.3.1
>
>
- [Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests, Wei Huang, 2016/12/06
- [Qemu-devel] [kvm-unit-tests PATCH v14 3/5] arm: Add PMU test, Wei Huang, 2016/12/06
- [Qemu-devel] [kvm-unit-tests PATCH v14 2/5] arm: Add support for read_sysreg() and write_sysreg(), Wei Huang, 2016/12/06
- [Qemu-devel] [kvm-unit-tests PATCH v14 4/5] arm: pmu: Check cycle count increases, Wei Huang, 2016/12/06
- [Qemu-devel] [kvm-unit-tests PATCH v14 1/5] arm: rename cp15.h to sysreg.h, Wei Huang, 2016/12/06
- [Qemu-devel] [kvm-unit-tests PATCH v14 5/5] arm: pmu: Add CPI checking, Wei Huang, 2016/12/06
- Re: [Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests,
Andrew Jones <=