Re: [Qemu-devel] [PATCH 01/25] tcg: Add clz and ctz opcodes

[Richard Henderson]

On 11/21/2016 04:11 PM, Alex Bennée wrote:
> > > +        case INDEX_op_clz_i32:
> > > +        case INDEX_op_ctz_i32:
> > > +            mask = temp_info(args[2])->mask | 31;
> > > +            break;
> > > +
> > > +        case INDEX_op_clz_i64:
> > > +        case INDEX_op_ctz_i64:
> > > +            mask = temp_info(args[2])->mask | 63;
> > > +            break;
> > > +
> Did I miss a pre-requisite here?
>
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c: In function ‘tcg_optimize’:
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c:900:20: error: implicit 
> declaration of function ‘temp_info’ [-Werror=implicit-function-declaration]
>              mask = temp_info(args[2])->mask | 31;
>                     ^
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c:900:13: error: nested extern 
> declaration of ‘temp_info’ [-Werror=nested-externs]
>              mask = temp_info(args[2])->mask | 31;
>              ^
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c:900:38: error: invalid type argument 
> of ‘->’ (have ‘int’)
>              mask = temp_info(args[2])->mask | 31;
>                                       ^
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c:905:38: error: invalid type argument 
> of ‘->’ (have ‘int’)
>              mask = temp_info(args[2])->mask | 63;
>                                       ^
> /home/alex/lsrc/qemu/qemu.git/tcg/optimize.c:1067:46: error: invalid type argument 
> of ‘->’ (have ‘int’)
>                  TCGArg v = temp_info(args[1])->val;
>                                               ^
> cc1: all warnings being treated as errors
> /home/alex/lsrc/qemu/qemu.git/rules.mak:60: recipe for target 'tcg/optimize.o' 
> failed

Hmm, it would appear that I posted the series from the wrong branch, where I 
had other changes installed.

I can re-post later.  In the meantime you could have a look at the branch:

  git://github.com/rth7680/qemu.git tcg-2.9


r~