Re: [Qemu-devel] [PATCH v3 1/8] tests: check-qom-proplist: Remove duplicate "bv" property

[Igor Mammedov]

On Wed, 26 Oct 2016 14:30:19 -0200
Eduardo Habkost <address@hidden> wrote:

> The object_property_add_bool() call in dummy_init() is always
> failing because there is an existing "bv" class property. We need
> to remove either the "bv" class property or the "bv" instance
> property.
> 
> Remove the class property so both object properties and class
> properties are covered by the test code.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
> Changes series v2 -> v3:
> * Reworded commit message for clarity
> ---
>  tests/check-qom-proplist.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index a16cefc..693dc4c 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -129,10 +129,6 @@ static void dummy_init(Object *obj)
>  
>  static void dummy_class_init(ObjectClass *cls, void *data)
>  {
> -    object_class_property_add_bool(cls, "bv",
> -                                   dummy_get_bv,
> -                                   dummy_set_bv,
> -                                   NULL);
>      object_class_property_add_str(cls, "sv",
>                                    dummy_get_sv,
>                                    dummy_set_sv,