Re: [Qemu-devel] [PATCH v3 5/8] qdev: Register static properties as class properties

[Igor Mammedov]

On Wed, 26 Oct 2016 14:30:23 -0200
Eduardo Habkost <address@hidden> wrote:

> Instead of registering qdev static properties on instance_init,
> register them as class properties, at qdev_class_set_props().
> 
> qdev_property_add_legacy() was replaced by an equivalent
> qdev_class_property_add_legacy() function.
> qdev_property_add_static(), on the other hand, can't be
> eliminated yet because it is used by arm_cpu_post_init().
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes series v1 -> v2:
> * (none)
> 
> Changes v2 -> v3:
> * Fix code alignemnt
>   * Reported-by: Igor Mammedov <address@hidden>
> ---
>  hw/core/qdev.c | 71 
> ++++++++++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 59 insertions(+), 12 deletions(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 85952e8..a88753c 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -739,12 +739,12 @@ static void qdev_get_legacy_property(Object *obj, 
> Visitor *v,
>  }
>  
>  /**
> - * qdev_property_add_legacy:
> - * @dev: Device to add the property to.
> + * qdev_class_property_add_legacy:
> + * @oc: Device to add the property to.
s/Device/Class/


>   * @prop: The qdev property definition.
>   * @errp: location to store error information.
>   *
> - * Add a legacy QOM property to @dev for qdev property @prop.
> + * Add a legacy QOM property to @oc for qdev property @prop.
>   * On error, store error in @errp.
>   *
>   * Legacy properties are string versions of QOM properties.  The format of
[...]

"make V=1 check" fails for me with this patch applied:

QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 QTEST_QEMU_IMG=qemu-img 
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose 
-m=quick  tests/device-introspect-test tests/qom-test
TEST: tests/device-introspect-test... (pid=275141)
  /aarch64/device/introspect/list:                                     OK
  /aarch64/device/introspect/none:                                     OK
  /aarch64/device/introspect/abstract:                                 OK
  /aarch64/device/introspect/concrete:                                 
Unexpected error in object_property_find() at 
/home/imammedo/builds/qemu/qom/object.c:1002:
Property '.disable_vnet_hdr' not found
Broken pipe
FAIL
GTester: last random seed: R02Se62da1d190b80e3301072daa8e4eab92
(pid=275152)
FAIL: tests/device-introspect-test
TEST: tests/qom-test... (pid=275153)