[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reo
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple() |
Date: |
Tue, 11 Oct 2016 11:39:49 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 10.10.2016 um 18:41 hat Paolo Bonzini geschrieben:
> On 10/10/2016 17:37, Kevin Wolf wrote:
> > > + while ((job = block_job_next(job))) {
> > > + AioContext *aio_context = blk_get_aio_context(job->blk);
> > > +
> > > + aio_context_acquire(aio_context);
> > > + block_job_pause(job);
> > > + aio_context_release(aio_context);
> > > + }
> > > +
> > > bdrv_drain_all();
> >
> > We already have a bdrv_drain_all() here, which does the same thing (and
> > more) internally, except that it resumes all jobs before it returns.
> > Maybe what we should do is split bdrv_drain_all() in a begin/end pair,
> > too.
>
> Hey, haven't I just suggested the same? :) I swear I hadn't read this
> before.
>
> > The other point I'm wondering now is whether bdrv_drain_all() should
> > have the aio_disable/enable_external() pair that bdrv_drain() has.
>
> bdrv_drain_all need not have it, but its start/end replacement should.
Doesn't need it because it holds the AioContext lock?
Kevin
- Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer, (continued)
- [Qemu-devel] [PATCH v10 06/16] block: Block all nodes involved in the block-commit operation, Alberto Garcia, 2016/10/06
- [Qemu-devel] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start(), Alberto Garcia, 2016/10/06
- [Qemu-devel] [PATCH v10 02/16] block: Add block_job_add_bdrv(), Alberto Garcia, 2016/10/06
- [Qemu-devel] [PATCH v10 08/16] block: Support streaming to an intermediate layer, Alberto Garcia, 2016/10/06
- [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start(), Alberto Garcia, 2016/10/06