[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mi
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job() |
|
Date: |
Tue, 11 Oct 2016 15:46:56 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 10 Oct 2016 06:03:41 PM CEST, Kevin Wolf wrote:
>> Use block_job_add_bdrv() instead of blocking all operations in
>> mirror_start_job() and unblocking them in mirror_exit().
>>
>> Signed-off-by: Alberto Garcia <address@hidden>
>
> Compared to the old code, this unblocks BLOCK_OP_TYPE_DATAPLANE, i.e.
> you can now run a dataplane device on a BDS used as the mirror target.
>
> This means that the target could require a different AioContext than
> the source, which we can't support. So it seems unlikely to me that we
> can lift this restriction.
Thanks, I'll fix it.
What happens if you run a dataplane on the source, though? That's
currently allowed as far as I'm aware. Wouldn't that have a similar
effect?
Berto
- Re: [Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple(), (continued)
[Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 04/16] block: Use block_job_add_bdrv() in backup_start(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 16/16] qemu-iotests: Test streaming to a Quorum child, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 10/16] docs: Document how to stream to an intermediate layer, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 15/16] qemu-iotests: Add iotests.supports_quorum(), Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 13/16] qemu-iotests: Test overlapping stream and commit operations, Alberto Garcia, 2016/10/06
[Qemu-devel] [PATCH v10 12/16] qemu-iotests: Test block-stream operations in parallel, Alberto Garcia, 2016/10/06