Re: [Qemu-devel] [PULL 00/15] Migration

[Peter Maydell]

On 5 October 2016 at 14:44, Juan Quintela <address@hidden> wrote:
> From: Juan Quintela <address@hidden>
>
> The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
> (2016-10-04 14:25:08 +0100)
>
> are available in the git repository at:
>
>   git://github.com/juanquintela/qemu.git tags/migration/20161005-1
>
> for you to fetch changes up to c62da143b6792cc32dbd5db15b936d7f58cc36ee:
>
>   docs/xbzrle: correction (2016-10-05 14:28:41 +0200)
>
> ----------------------------------------------------------------
> migration/next for 20161005
>
> Hi
>
> This get:
> - documentation fix: Cao
> - improve max-bandwidth and downtime-limit (Ashijeet)
> - move migration commands to "boxed" (Eric)
> - rdma fixes (David)
> - postcopy fixes (David)
> - better errors (David)
>
> Please apply

This runs into the "OSX %zu vs SIZE_MAX" issue again:

/Users/pm215/src/qemu-for-merges/migration/migration.c:810:61:
warning: format specifies type 'size_t' (aka 'unsigned long') but the
argument has type 'unsigned long long' [-Wformat]
                         " range of 0 to %zu bytes/second", SIZE_MAX);
                                         ~~~                ^~~~~~~~
                                         %llu
/Users/pm215/src/qemu-for-merges/include/qapi/error.h:163:35: note:
expanded from macro 'error_setg'
                        (fmt), ## __VA_ARGS__)
                                  ^
/usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
#define SIZE_MAX          UINT64_MAX
                          ^~~~~~~~~~
/usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
#define UINT64_MAX        18446744073709551615ULL
                          ^~~~~~~~~~~~~~~~~~~~~~~

In the absence of a suitable configure test and override of SIZE_MAX,
we've been adding explicit (uint64_t) casts in the printf as the
simplest workaround.

thanks
-- PMM