Re: [Qemu-devel] [PATCH v4 00/17] Convert VFIO-PCI to realize

[Alex Williamson]

On Tue, 04 Oct 2016 15:20:12 +0200
Markus Armbruster <address@hidden> wrote:

> Eric Auger <address@hidden> writes:
> 
> > This series converts VFIO-PCI to realize. It also aims at improving
> > the error reporting in case of QMP hot-plug.
> >
> > Before the series, a device_add failure would have reported:
> > {"error": {"class": "GenericError", "desc": "Device initialization
> > failed"}}.
> >
> > Now the actual error cause is reported.
> >
> > A side effect of this series is the cleanup of the error handling
> > in vfio-platform.  
> 
> Only a few really minor issues left, so series
> Reviewed-by: Markus Armbruster <address@hidden>

Eric, thanks for doing this conversion and thanks to Markus for the
thorough reviews.  One tiny nit I see is patch 06/17 does this:

> @@ -1189,6 +1189,7 @@ static int vfio_msi_setup(VFIOPCIDevice *vdev, int pos)
>  
>      if (pread(vdev->vbasedev.fd, &ctrl, sizeof(ctrl),
>                vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) {
> +        error_setg_errno(errp, errno, "failed reading PCI_CAP_FLAGS");
>          return -errno;
>      }

And that new error string might be more useful if it were "failed
reading MSI PCI_CAP_FLAGS".  Unless some sort of MSI hint gets added
somewhere that I'm missing.

Markus noted a few things that could be fixed on commit and several
others that I don't want to decide for you, so I'll look forward to a
v5 to wrap this up.  Thanks!

Alex