[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 13/17] vfio/platform: Pass an error object to
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 13/17] vfio/platform: Pass an error object to vfio_base_device_init |
Date: |
Tue, 04 Oct 2016 14:53:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Auger <address@hidden> writes:
> This patch propagates errors encountered during vfio_base_device_init
> up to the realize function.
>
> Signed-off-by: Eric Auger <address@hidden>
>
> ---
>
> v3: creation
> ---
> hw/vfio/platform.c | 49 ++++++++++++++++++++++++++-----------------------
> 1 file changed, 26 insertions(+), 23 deletions(-)
>
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index 484e31f..fc06b45 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -541,13 +541,14 @@ static VFIODeviceOps vfio_platform_ops = {
> /**
> * vfio_base_device_init - perform preliminary VFIO setup
> * @vbasedev: the VFIO device handle
> + * @errp: error object
> *
> * Implement the VFIO command sequence that allows to discover
> * assigned device resources: group extraction, device
> * fd retrieval, resource query.
> * Precondition: the device name must be initialized
> */
> -static int vfio_base_device_init(VFIODevice *vbasedev)
> +static int vfio_base_device_init(VFIODevice *vbasedev, Error **errp)
> {
> VFIOGroup *group;
> VFIODevice *vbasedev_iter;
> @@ -555,7 +556,6 @@ static int vfio_base_device_init(VFIODevice *vbasedev)
> ssize_t len;
> struct stat st;
> int groupid;
> - Error *err = NULL;
> int ret;
>
> /* @sysfsdev takes precedence over @host */
> @@ -564,6 +564,7 @@ static int vfio_base_device_init(VFIODevice *vbasedev)
> vbasedev->name = g_strdup(basename(vbasedev->sysfsdev));
> } else {
> if (!vbasedev->name || strchr(vbasedev->name, '/')) {
> + error_setg(errp, "wrong host device name");
Error is no longer silent. Worth mentioning in the commit message?
> return -EINVAL;
> }
>
> @@ -572,8 +573,7 @@ static int vfio_base_device_init(VFIODevice *vbasedev)
> }
>
> if (stat(vbasedev->sysfsdev, &st) < 0) {
> - error_report("vfio: error: no such host device: %s",
> - vbasedev->sysfsdev);
> + error_setg_errno(errp, errno, "no such host device");
"no such host device" is correct and now redundant when errno is ENOENT,
and misleading when it isn't. Suggest to rephrase the message.
> return -errno;
> }
>
[...]
- [Qemu-devel] [PATCH v4 15/17] vfio/pci: Remove vfio_msix_early_setup returned value, (continued)
- [Qemu-devel] [PATCH v4 14/17] vfio/pci: Conversion to realize, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 16/17] vfio/pci: Remove vfio_populate_device returned value, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 13/17] vfio/platform: Pass an error object to vfio_base_device_init, Eric Auger, 2016/10/03
- Re: [Qemu-devel] [PATCH v4 13/17] vfio/platform: Pass an error object to vfio_base_device_init,
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 17/17] vfio/pci: Handle host oversight, Eric Auger, 2016/10/03
- Re: [Qemu-devel] [PATCH v4 00/17] Convert VFIO-PCI to realize, Markus Armbruster, 2016/10/04