[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" er
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" errors? |
|
Date: |
Tue, 4 Oct 2016 15:57:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/04/2016 01:22 PM, Eduardo Habkost wrote:
> On Mon, Oct 03, 2016 at 03:15:39PM -0500, Eric Blake wrote:
> [...]
>>> 3.2) Removing the unimplemented command from query-commands only
>>> (by calling qmp_disable_command()), but keeping it on the QAPI
>>> schema. I am not sure it's OK to do that. If it is, this
>>> sounds like the simplest solution.
>>
>> We already have existing commands in this category, and it is
>> conceptually the easiest (if query-commands doesn't list the command,
>> then the command doesn't work even if the introspection still shows it).
> [...]
>
> Which commands are already in this category? I don't see any
> qmp_disable_command() calls on the tree except for guest agent
> code.
Probably a typo on my side; commit 5032a16d adds the use of
qmp_unregister_command(), not qmp_disable_command().
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature