[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" er
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" errors? |
|
Date: |
Tue, 4 Oct 2016 15:22:34 -0300 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Oct 03, 2016 at 03:15:39PM -0500, Eric Blake wrote:
[...]
> > 3.2) Removing the unimplemented command from query-commands only
> > (by calling qmp_disable_command()), but keeping it on the QAPI
> > schema. I am not sure it's OK to do that. If it is, this
> > sounds like the simplest solution.
>
> We already have existing commands in this category, and it is
> conceptually the easiest (if query-commands doesn't list the command,
> then the command doesn't work even if the introspection still shows it).
[...]
Which commands are already in this category? I don't see any
qmp_disable_command() calls on the tree except for guest agent
code.
--
Eduardo