Re: [Qemu-devel] [PATCH v3 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

[Radim Krčmář]

2016-10-04 14:18+0200, Igor Mammedov:
> On Fri, 30 Sep 2016 18:10:12 +0200
> Radim Krčmář <address@hidden> wrote:
>> QEMU 2.7 allowed EIM even in configurations that were forbidden in the
>> last patch because they were not working, like old KVM or userspace
>> APIC.  In order to keep backward compatibility, we again allow guests to
>> misbehave in non-obvious ways, and make it the default.
>> 
>> Signed-off-by: Radim Krčmář <address@hidden>
>> ---
>> v3: shorten the code [Peter]
>> ---
>> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
>> @@ -2456,9 +2456,11 @@ static AddressSpace *vtd_host_dma_iommu(PCIBus *bus, 
>> void *opaque, int devfn)
>> -static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
>> +static bool vtd_decide_config(IntelIOMMUState *s, PCMachineState *pcms,
>> +                              Error **errp)
>>  {
>>      X86IOMMUState *x86_iommu = X86_IOMMU_DEVICE(s);
>> +    PCMachineClass *pcmc = PC_MACHINE_CLASS(MACHINE_GET_CLASS(pcms));
> It's a bit backwards, for devices we usually add a property to affected device
> and use compat macros to do the job. As example look at
> commit 048a2e8869cb7e26013e40d860c9ebdf8e28c2ac
>     x86: ioapic: boost default version to 0x20

I see, v4 will have a property.  Thanks.