[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [virtio-dev] Re: [PATCH v5] virtio-crypto: Add virtio c
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [virtio-dev] Re: [PATCH v5] virtio-crypto: Add virtio crypto device specification |
Date: |
Sat, 30 Jul 2016 02:11:35 +0000 |
> -----Original Message-----
> From: address@hidden [mailto:address@hidden
> On Behalf Of Michael S. Tsirkin
> Sent: Friday, July 29, 2016 1:34 PM
> To: Zeng, Xin
> Cc: Gonglei (Arei); address@hidden; address@hidden;
> Ola Liljedahl; Keating, Brian A; Hanweidong (Randy); Luonengjun; Huangpeng
> (Peter); Griffin, John; Ma, Liang J; Stefan Hajnoczi; Cornelia Huck; Varun
> Sethi;
> Jani Kokkonen; Lingli Deng; Huangweidong (C)
> Subject: [virtio-dev] Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio
> crypto
> device specification
>
> On Thu, Jul 28, 2016 at 05:28:33AM +0000, Zeng, Xin wrote:
> > On Thursday, July 28, 2016 10:51 AM Gonglei (Arei) Wrote:
> > > > > Changes from v4:
> > > > > - introduce crypto services into virtio crypto device. The services
> > > > > currently defined are CIPHER, MAC, HASH, AEAD, KDF, ASYM,
> > > > PRIMITIVE.
> > > > > - define a unified crypto request format that is consisted of
> > > > > general header + service specific request, Where 'general header'
> is for
> > > > all
> > > > > crypto request, 'service specific request' is composed of
> > > > > operation parameter + input data + output data in generally.
> > > > > operation parameter is algorithm-specific parameters,
> > > > > input data is the data should be operated ,
> > > > > output data is the "operation result + result buffer".
> > > > > - redefine the algorithms and structure based on above crypto
> services.
> > > > > - rearrange the title and subtitle
> > > > > - Only support CIPHER, MAC, HASH and AEAD crypto services, and Xin
> will
> > > > > focus KDF, ASYM and PRIMITIVE services.
> > > > > - Some other corresponding fixes.
> > > > > - Make a formal patch using tex type.
> > > > >
> > > > > Changes from v3:
> > > > > - Don't use enum is the spec but macros in specific structures.
> [Michael &
> > > > Stefan]
> > > > > - Add two complete structures for session creation and closing, so
> that
> > > > > the spec is clear on how to lay out the request. [Stefan]
> > > > > - Definite the crypto operation request with assigned structure, in
> > > > > this
> > > way,
> > > > > each data request only occupies *one entry* of the Vring descriptor
> > > table,
> > > > > which *improves* the *throughput* of data transferring.
> > > > >
> > > > > Changes from v2:
> > > > > - Reserve virtio device ID 20 for crypto device. [Cornelia]
> > > > > - Drop all feature bits, those capabilities are offered by the
> > > > > device all
> the
> > > > time. [Stefan & Cornelia]
> > > > > - Add a new section 1.4.2 for driver requirements. [Stefan]
> > > > > - Use definite type definition instead of enum type in some
> > > > > structure.
> > > > [Stefan]
> > > > > - Add virtio_crypto_cipher_alg definition. [Stefan]
> > > > > - Add a "Device requirements" section as using MUST. [Stefan]
> > > > > - Some grammar nits fixes and typo fixes. [Stefan & Cornelia]
> > > > > - Add one VIRTIO_CRYPTO_S_STARTED status for the driver as the flag
> of
> > > > virtio-crypto device started and can work now.
> > > > >
> > > > > Great thanks for Stefan and Cornelia!
> > > > >
> > > > > Changes from v1:
> > > > > - Drop the feature bit definition for each algorithm, and using
> > > > > config
> > > space
> > > > instead [Cornelia]
> > > > > - Add multiqueue support and add corresponding feature bit
> > > > > - Update Encryption process and header definition
> > > > > - Add session operation process and add corresponding header
> > > description
> > > > > - Other better description in order to fit for virtio spec [Michael]
> > > > > - Some other trivial fixes.
> > > >
> > > > OK I will let people who understand crypto comment on this.
> > >
> > > Excellently, thanks!
> > >
> > > > Down the road before we release this we'll need to link confirmance
> > > clauses
> > > > from confirmance section. Can be a patch on top, no big deal.
> > > >
> > >
> > > Sorry, where is the confirmance section and what's confirmance clauses?
>
> I meant conformance :) The stuff in conformance.tex
>
Okay, I got it, I'll add a separate patch :)
Regards,
-Gonglei
- [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Gonglei, 2016/07/27
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Michael S. Tsirkin, 2016/07/27
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Gonglei (Arei), 2016/07/27
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/07/28
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Gonglei (Arei), 2016/07/29
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Michael S. Tsirkin, 2016/07/29
- Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Zeng, Xin, 2016/07/29
- Re: [Qemu-devel] [virtio-dev] Re: [PATCH v5] virtio-crypto: Add virtio crypto device specification,
Gonglei (Arei) <=
Re: [Qemu-devel] [PATCH v5] virtio-crypto: Add virtio crypto device specification, Stefan Hajnoczi, 2016/07/29