[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz |
Date: |
Wed, 27 Jul 2016 14:02:40 +1000 |
On Wed, 2016-07-27 at 12:36 +1000, David Gibson wrote:
> > - do_dcbz(env, addr, dcbz_size, GETPC());
> > + /* Try fast path translate */
> > + haddr = tlb_vaddr_to_host(env, addr, MMU_DATA_STORE, env->dmmu_idx);
>
> It worries me slightly that this doesn't take any length to verify. I
> guess it's ok in practice, because memory blocks will always be at
> least cache line size aligned.
It's safe ;-)
The translate returns a qemu page size address which is always 4K.
We don't need to verify because we just aligned the address to the
cache block size which is always smaller than 4k. So we can't
possibly be crossing a page boundary.
(grep for tlb_vaddr_to_host in target-s390 for other examples of use
of tlb_vaddr_to_host).
Cheers,
Ben.
- Re: [Qemu-devel] [PATCH 24/32] ppc: Make alignment exceptions suck less, (continued)
- [Qemu-devel] [PATCH 31/32] ppc: load/store multiple and string insns don't do LE, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 27/32] ppc: Fix CFAR updates, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 28/32] ppc: Avoid double translation for lvx/lvxl/stvx/stvxl, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 29/32] ppc: Don't set access_type on all load/stores on hash64, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 30/32] ppc: Use a helper to generate "LE unsupported" alignment interrupts, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 22/32] ppc: Don't update NIP if not taking alignment exceptions, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 32/32] ppc: Speed up load/store multiple, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 14/32] ppc: Don't update NIP in lmw/stmw/icbi, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 23/32] ppc: Don't update NIP in dcbz and lscbx, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 17/32] ppc: Fix source NIP on SLB related interrupts, Benjamin Herrenschmidt, 2016/07/26
- [Qemu-devel] [PATCH 25/32] ppc: Handle unconditional (always/never) traps at translation time, Benjamin Herrenschmidt, 2016/07/26
- Re: [Qemu-devel] [PATCH 01/32] ppc: Fix fault PC reporting for lve*/stve* VMX instructions, David Gibson, 2016/07/26