[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq |
Date: |
Tue, 19 Jul 2016 17:40:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/19/2016 02:54 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> qemu_irq is already a pointer, no need to have an extra pointer level.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/i386/pc.c | 8 ++++----
> hw/input/pckbd.c | 4 ++--
> include/hw/i386/pc.h | 2 +-
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 1b8baa8..57b09c9 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -533,9 +533,9 @@ static uint64_t port92_read(void *opaque, hwaddr addr,
> return ret;
> }
>
> -static void port92_init(ISADevice *dev, qemu_irq *a20_out)
> +static void port92_init(ISADevice *dev, qemu_irq a20_out)
qemu_irq type naming goes against our normal conventions. But this
isn't the series to change that.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 10/37] tests: fix check-qom-proplist leaks, (continued)
- [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visitor, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 13/37] portio: keep references on portio, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq, marcandre . lureau, 2016/07/19
- Re: [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq,
Eric Blake <=
- [Qemu-devel] [PATCH 14/37] numa: do not leak NumaOptions, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 16/37] pc: don't leak a20_line, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 17/37] machine: use class base init generated name, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 18/37] acpi-build: fix array leak, marcandre . lureau, 2016/07/19