[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visitor |
Date: |
Tue, 19 Jul 2016 17:37:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/19/2016 02:54 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Free the list returned by visit_type_intList().
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/test-string-input-visitor.c | 1 +
> 1 file changed, 1 insertion(+)
Hmm, I thought I'd fixed that under valgrind previously. But browsing
logs, I see where I touched other visitor tests but not this one. :)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/tests/test-string-input-visitor.c
> b/tests/test-string-input-visitor.c
> index d837ebe..a679fbc 100644
> --- a/tests/test-string-input-visitor.c
> +++ b/tests/test-string-input-visitor.c
> @@ -228,6 +228,7 @@ static void test_visitor_in_fuzz(TestInputVisitorData
> *data,
>
> v = visitor_input_test_init(data, buf);
> visit_type_intList(v, NULL, &ilres, NULL);
> + qapi_free_intList(ilres);
> visitor_input_teardown(data, NULL);
>
> v = visitor_input_test_init(data, buf);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 08/37] qdist: fix entries memory leak, (continued)
- [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visitor, marcandre . lureau, 2016/07/19
- Re: [Qemu-devel] [PATCH 12/37] tests: fix leak in test-string-input-visitor,
Eric Blake <=
- [Qemu-devel] [PATCH 13/37] portio: keep references on portio, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 15/37] pc: simplify passing qemu_irq, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 14/37] numa: do not leak NumaOptions, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 16/37] pc: don't leak a20_line, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 17/37] machine: use class base init generated name, marcandre . lureau, 2016/07/19
- [Qemu-devel] [PATCH 18/37] acpi-build: fix array leak, marcandre . lureau, 2016/07/19