Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

[Denis V. Lunev]

On 02/23/2016 01:47 PM, Amit Shah wrote:
> Hi Denis,
>
> On (Tue) 23 Feb 2016 [13:09:26], Amit Shah wrote:
> > On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote:
> > > There is a possibility to hit an assert in qcow2_get_specific_info that
> > > s->qcow_version is undefined. This happens when VM in starting from
> > > suspended state, i.e. it processes incoming migration, and in the same
> > > time 'info block' is called.
> > >
> > > The problem is that qcow2_invalidate_cache() closes the image and
> > > memset()s BDRVQcowState in the middle.
> > >
> > > This operation should not be performed in coroutine context.
> > >
> > > Changes from v1:
> > > - fixed spelling. Eric, thank you for spell checking
> > BTW I noticed this just now: the commit subject line for both the
> > patches is the same.  Please avoid that in the future.
> The pull req failed to apply due to another patchset - could you
> please do a v3 with better subject lines for the patches?
>
> Thanks,
>
>                 Amit
no prob, I'll send new patch later today.