[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of cor
|
From: |
Amit Shah |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context |
|
Date: |
Tue, 23 Feb 2016 13:09:26 +0530 |
On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote:
> There is a possibility to hit an assert in qcow2_get_specific_info that
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that qcow2_invalidate_cache() closes the image and
> memset()s BDRVQcowState in the middle.
>
> This operation should not be performed in coroutine context.
>
> Changes from v1:
> - fixed spelling. Eric, thank you for spell checking
BTW I noticed this just now: the commit subject line for both the
patches is the same. Please avoid that in the future.
Amit
- Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context, (continued)
[Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of of coroutine context, Denis V. Lunev, 2016/02/12
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context, Denis V. Lunev, 2016/02/16
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context, Amit Shah, 2016/02/18
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context, Denis V. Lunev, 2016/02/22
Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context,
Amit Shah <=