[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 6/6] xlnx-ep108: Connect the SPI Flash
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v7 6/6] xlnx-ep108: Connect the SPI Flash |
Date: |
Mon, 18 Jan 2016 08:49:17 -0800 |
On Mon, Jan 18, 2016 at 3:27 AM, Peter Maydell <address@hidden> wrote:
> On 15 January 2016 at 22:38, Alistair Francis
> <address@hidden> wrote:
>> Connect the sst25wf080 SPI flash to the EP108 board.
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>> Reviewed-by: Peter Crosthwaite <address@hidden>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> ---
>> hw/arm/xlnx-ep108.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c
>> index 9099025..4dc21c9 100644
>> --- a/hw/arm/xlnx-ep108.c
>> +++ b/hw/arm/xlnx-ep108.c
>> @@ -30,6 +30,7 @@ static struct arm_boot_info xlnx_ep108_binfo;
>> static void xlnx_ep108_init(MachineState *machine)
>> {
>> XlnxEP108 *s = g_new0(XlnxEP108, 1);
>> + int i;
>> Error *err = NULL;
>> uint64_t ram_size = machine->ram_size;
>>
>> @@ -62,6 +63,20 @@ static void xlnx_ep108_init(MachineState *machine)
>> exit(1);
>> }
>>
>> + for (i = 0; i < XLNX_ZYNQMP_NUM_SPIS; i++) {
>> + SSIBus *spi_bus;
>> + DeviceState *flash_dev;
>> + qemu_irq cs_line;
>> + gchar *bus_name = g_strdup_printf("spi%d", i);
>> +
>> + spi_bus = (SSIBus *)qdev_get_child_bus(DEVICE(&s->soc), bus_name);
>> +
>> + flash_dev = ssi_create_slave(spi_bus, "sst25wf080");
>> + cs_line = qdev_get_gpio_in_named(flash_dev, SSI_GPIO_CS, 0);
>> +
>> + sysbus_connect_irq(SYS_BUS_DEVICE(&s->soc.spi[i]), 1, cs_line);
>> + }
>
> You forgot to g_free(bus_name). I'll add that to this (and the
> similar place in the previous patch) when I add these to target-arm.next.
Thanks! I'm sorry for that I just completely forgot.
Thanks,
Alistair
>
> thanks
> -- PMM
>
- [Qemu-devel] [PATCH v7 0/6] Connect the SPI devices to Xilinx's ZynqMP., Alistair Francis, 2016/01/15
- [Qemu-devel] [PATCH v7 1/6] qdev: get_child_bus(): Use QOM lookup if available, Alistair Francis, 2016/01/15
- [Qemu-devel] [PATCH v7 2/6] m25p80.c: Add sst25wf080 SPI flash device, Alistair Francis, 2016/01/15
- [Qemu-devel] [PATCH v7 3/6] ssi: Move ssi.h into a separate directory, Alistair Francis, 2016/01/15
- [Qemu-devel] [PATCH v7 4/6] xilinx_spips: Separate the state struct into a header, Alistair Francis, 2016/01/15
- [Qemu-devel] [PATCH v7 6/6] xlnx-ep108: Connect the SPI Flash, Alistair Francis, 2016/01/15
- Message not available
- Re: [Qemu-devel] [PATCH v7 0/6] Connect the SPI devices to Xilinx's ZynqMP., Peter Maydell, 2016/01/18