qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 07/23] qemu-nbd: Clean up "Failed to load sna


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 07/23] qemu-nbd: Clean up "Failed to load snapshot" error message
Date: Thu, 17 Dec 2015 13:17:23 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 12/17/2015 09:49 AM, Markus Armbruster wrote:
> bdrv_snapshot_load_tmp() sets an error and returns -errno on failure.
> We report both even though the error message is self-contained.  Drop
> the redundant strerror().
> 
> While there: setting errno right before exit() is pointless, so drop
> that, too.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-nbd.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]