Re: [Qemu-devel] [PATCH v2 06/23] block: Clean up "Could not create temporary overlay" error message

[Eric Blake]

On 12/17/2015 09:49 AM, Markus Armbruster wrote:
> bdrv_create() sets an error and returns -errno on failure.  When the
> latter is interesting, the error is created with error_setg_errno().
> 
> bdrv_append_temp_snapshot() uses the error's message to create a new
> one with error_setg_errno().  This adds a strerror() that is either
> uninteresting or duplicate.  Use error_setg() instead.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature