qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compi


From: Richard Henderson
Subject: Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile
Date: Fri, 11 Dec 2015 09:25:06 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

On 12/11/2015 05:41 AM, Peter Maydell wrote:
Hi; I noticed while grepping through code that the version of
tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
won't compile because it's still referring to the no-longer-existent
TCGContext::gen_opc_buf.

Oops.

Richard, I think this was probably broken as part of your changes to
use a linked list of ops instead. Should we update the dummy function,
or just delete it on the grounds nobody noticed it was broken? :-)

(There are also 3 now-stale comments in the tree that refer to
gen_opc_buf still.)

I guess we should keep it, since it's so easy to do so.
Patch to follow.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]