[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump"
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump" |
Date: |
Mon, 7 Dec 2015 15:03:09 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Dec 07, 2015 at 02:21:44PM +0800, Fam Zheng wrote:
> On Mon, 12/07 13:56, Peter Xu wrote:
> > /* send DUMP_COMPLETED message (unconditionally) */
> > - qapi_event_send_dump_completed(!!local_err, (local_err ? \
> > + result = qmp_query_dump(NULL);
> > + /* should never fails */
>
> s/fails/fail/
Got.
>
> > diff --git a/qmp-commands.hx b/qmp-commands.hx
> > index 7b6f915..eb5bfe2 100644
> > --- a/qmp-commands.hx
> > +++ b/qmp-commands.hx
> > @@ -858,8 +858,9 @@ Arguments:
> > - "protocol": destination file(started with "file:") or destination file
> > descriptor (started with "fd:") (json-string)
> > - "detach": if specified, command will return immediately rather than
> > waiting
> > - for the dump completion. A DUMP_COMPLETED event will occur at
> > - the end. (json-bool)
> > + for the dump completion. The user can track progress using
> > + "query-dump" A DUMP_COMPLETED event will occur at the
>
> Missing "." before "A DUMP_COMPLETED"?
Possibly... Changing both. Thanks!
Peter
>
> > + end. (json-bool)
- [Qemu-devel] [PATCH v5 04/11] dump-guest-memory: add dump_in_progress() helper function, (continued)
- [Qemu-devel] [PATCH v5 04/11] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 05/11] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 07/11] dump-guest-memory: add "detach" support, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 09/11] DumpState: adding total_size and written_size fields, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump", Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 11/11] Dump: add hmp command "info dump", Peter Xu, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Fam Zheng, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Eric Blake, 2015/12/07