[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when i
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state |
Date: |
Mon, 7 Dec 2015 14:14:11 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 12/07 13:56, Peter Xu wrote:
> Signed-off-by: Peter Xu <address@hidden>
> ---
> dump.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/dump.c b/dump.c
> index f0ee9a8..aa9d1f8 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const char
> *file,
> DumpState *s;
> Error *local_err = NULL;
>
> + if (runstate_check(RUN_STATE_INMIGRATE)) {
> + error_setg(errp, "Dump not allowed during incoming migration.");
> + return;
> + }
> +
Detached dump when "inmigrate" is disabled, that's OK. But what about sync
dump? It used to be possible, but now is disabled. Just asking to make sure
this is the intention rather than oversight.
Fam
> /* if there is a dump in background, we should wait until the dump
> * finished */
> if (dump_in_progress()) {
> --
> 2.4.3
>
- [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}()., Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 03/11] dump-guest-memory: using static DumpState, add DumpStatus, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 04/11] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 05/11] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 06/11] dump-guest-memory: disable dump when in INMIGRATE state,
Fam Zheng <=
- [Qemu-devel] [PATCH v5 07/11] dump-guest-memory: add "detach" support, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 09/11] DumpState: adding total_size and written_size fields, Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 10/11] Dump: add qmp command "query-dump", Peter Xu, 2015/12/07
- [Qemu-devel] [PATCH v5 11/11] Dump: add hmp command "info dump", Peter Xu, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Fam Zheng, 2015/12/07
- Re: [Qemu-devel] [PATCH v5 00/11] Add basic "detach" support for dump-guest-memory, Eric Blake, 2015/12/07