[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 assert
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts |
Date: |
Mon, 5 Oct 2015 13:14:00 +0200 |
Hi
On Mon, Oct 5, 2015 at 12:56 PM, Claudio Fontana
<address@hidden> wrote:
> Hi, I did not find g_assertion_message in any of the exported GLIB APIs.
> In fact, I found it in glib/gtestutils.h under the section "internal ABI".
> This is a hint that we should not be using it right?
Good point, I didn't see that. Notice that this file has other weird
comments, such as "semi-internal API". I think it's fine to use
though, because it's an external symbol and glib has ABI stability
guarantees. I opened https://bugzilla.gnome.org/show_bug.cgi?id=756077
to change the glib comments.
--
Marc-André Lureau
- [Qemu-devel] [PATCH v5 33/48] ivshmem-server: use a uint16 for client ID, (continued)
- [Qemu-devel] [PATCH v5 33/48] ivshmem-server: use a uint16 for client ID, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 36/48] ivshmem: add check on protocol version in QEMU, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 39/48] qtest: add qtest_add_abrt_handler(), marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 46/48] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 06/48] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 14/48] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 03/48] ivhsmem: read do not accept more than sizeof(long), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 08/48] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 27/48] ivshmem: fix pci_ivshmem_exit(), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 41/48] tests: add ivshmem qtest, marcandre . lureau, 2015/10/08