[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 assert
|
From: |
Claudio Fontana |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts |
|
Date: |
Mon, 5 Oct 2015 16:41:15 +0200 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 05.10.2015 15:35, Marc-André Lureau wrote:
> glib comment is now fixed:
>
> https://git.gnome.org/browse/glib/commit/?id=dabf6627886c1d21b9fe03c897809eb64ef2ac54
>
Good!
> On Mon, Oct 5, 2015 at 1:44 PM, Paolo Bonzini <address@hidden> wrote:
>>
>>
>> On 05/10/2015 12:56, Claudio Fontana wrote:
>>> Hi, I did not find g_assertion_message in any of the exported GLIB APIs.
>>> In fact, I found it in glib/gtestutils.h under the section "internal ABI".
>>> This is a hint that we should not be using it right?
>>
>> Since this only matters for these pre-2.46 versions, where we know that
>> g_assertion_message exists, we can use it.
>>
>> Paolo
This is also a valid point.
Reviewed-by: Claudio Fontana <address@hidden>
- Re: [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server, (continued)
[Qemu-devel] [PATCH v5 46/48] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 06/48] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 14/48] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 03/48] ivhsmem: read do not accept more than sizeof(long), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 08/48] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 27/48] ivshmem: fix pci_ivshmem_exit(), marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 41/48] tests: add ivshmem qtest, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 35/48] docs: update ivshmem device spec, marcandre . lureau, 2015/10/08
[Qemu-devel] [PATCH v5 12/48] ivshmem: simplify around increase_dynamic_storage(), marcandre . lureau, 2015/10/08