[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} com
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands |
Date: |
Mon, 31 Aug 2015 09:08:30 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Yang Hongyang <address@hidden> writes:
> On 08/28/2015 07:37 PM, Markus Armbruster wrote:
[...]
>> To make progress, I suggest you try the following:
>>
>> 1. Make NetFilter a flat union, as I suggested in my review of PATCH 2.
>>
>> 2. Use Eric's idea above, because it avoids the dependency on code
>> that's still under review.
>>
>> Drawback: extra layer of nesting. Ugly, but not the end of the world,
>> and we still have a chance to peel it off before the next release.
>
> Thanks for the explanation, I will try to see if I can fully understand
> your point.
If you have questions on the QAPI part, Eric and I will be happy to
answer them.
- Re: [Qemu-devel] [PATCH v8 04/11] netfilter: hook packets before net queue send, (continued)
- [Qemu-devel] [PATCH v8 02/11] init/cleanup of netfilter object, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/26
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Markus Armbruster, 2015/08/26
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Eric Blake, 2015/08/26
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Markus Armbruster, 2015/08/28
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/30
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/31
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Eric Blake, 2015/08/31
- Re: [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/31
[Qemu-devel] [PATCH v8 05/11] move out net queue structs define, Yang Hongyang, 2015/08/26
[Qemu-devel] [PATCH v8 06/11] netfilter: add an API to pass the packet to next filter, Yang Hongyang, 2015/08/26
[Qemu-devel] [PATCH v8 08/11] net/queue: export qemu_net_queue_append_iov, Yang Hongyang, 2015/08/26
[Qemu-devel] [PATCH v8 07/11] netfilter: print filter info associate with the netdev, Yang Hongyang, 2015/08/26