[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define |
Date: |
Thu, 27 Aug 2015 16:38:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
Maybe add a short comment why/where this is needed later?
On 26/08/15 11:59, Yang Hongyang wrote:
> Signed-off-by: Yang Hongyang <address@hidden>
> ---
> include/net/queue.h | 19 +++++++++++++++++++
> net/queue.c | 19 -------------------
> 2 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/include/net/queue.h b/include/net/queue.h
> index fc02b33..1d65e47 100644
> --- a/include/net/queue.h
> +++ b/include/net/queue.h
> @@ -31,6 +31,25 @@ typedef struct NetQueue NetQueue;
>
> typedef void (NetPacketSent) (NetClientState *sender, ssize_t ret);
>
> +struct NetPacket {
> + QTAILQ_ENTRY(NetPacket) entry;
> + NetClientState *sender;
> + unsigned flags;
> + int size;
> + NetPacketSent *sent_cb;
> + uint8_t data[0];
> +};
> +
> +struct NetQueue {
> + void *opaque;
> + uint32_t nq_maxlen;
> + uint32_t nq_count;
> +
> + QTAILQ_HEAD(packets, NetPacket) packets;
> +
> + unsigned delivering:1;
> +};
> +
> #define QEMU_NET_PACKET_FLAG_NONE 0
> #define QEMU_NET_PACKET_FLAG_RAW (1<<0)
>
> diff --git a/net/queue.c b/net/queue.c
> index ebbe2bb..1499479 100644
> --- a/net/queue.c
> +++ b/net/queue.c
> @@ -39,25 +39,6 @@
> * unbounded queueing.
> */
>
> -struct NetPacket {
> - QTAILQ_ENTRY(NetPacket) entry;
> - NetClientState *sender;
> - unsigned flags;
> - int size;
> - NetPacketSent *sent_cb;
> - uint8_t data[0];
> -};
> -
> -struct NetQueue {
> - void *opaque;
> - uint32_t nq_maxlen;
> - uint32_t nq_count;
> -
> - QTAILQ_HEAD(packets, NetPacket) packets;
> -
> - unsigned delivering : 1;
> -};
> -
> NetQueue *qemu_new_net_queue(void *opaque)
> {
> NetQueue *queue;
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v8 04/11] netfilter: hook packets before net queue send, (continued)
- [Qemu-devel] [PATCH v8 04/11] netfilter: hook packets before net queue send, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 02/11] init/cleanup of netfilter object, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 05/11] move out net queue structs define, Yang Hongyang, 2015/08/26
- Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define,
Thomas Huth <=
- [Qemu-devel] [PATCH v8 06/11] netfilter: add an API to pass the packet to next filter, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 08/11] net/queue: export qemu_net_queue_append_iov, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 07/11] netfilter: print filter info associate with the netdev, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 09/11] netfilter: add a netbuffer filter, Yang Hongyang, 2015/08/26
- [Qemu-devel] [PATCH v8 10/11] filter/buffer: update command description and help, Yang Hongyang, 2015/08/26