Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

[Samuel Thibault]

Jan Kiszka, le Wed 29 Jul 2015 09:58:36 +0200, a écrit :
> On 2015-07-29 09:47, Samuel Thibault wrote:
> > Ok. Two of the patches are however from a different author, I haven't
> > found how to specify different From addresses with git send-email.
> 
> This knowledge is buried in scripts here, but IIRC it should suffice
> having recorded authorship correctly in git.

Ok.

> >> Also, some are signed-off by you, others not. As a maintainer, you
> >> should sign all of them. Or is there a particular reason (not yet
> >> reviewed etc.)?
> > 
> > The reason was just that I hadn't touched those patches at all, but I
> > reviewed them all.
> 
> If you touch a patch and it's just trivial, add a simple changelog like
> 
> Signed-off-by: Author ....
> [Samuel: fix minor style issue etc.]
> Signed-off-by: You

Well, I have to say I really don't remember what I changed myself, since
that was more than 2 years ago already.  I'd have to go through the
whole git log to find the information.

> If you change the patch significantly, rather remove the authors
> signed-off and ask to provide it again for the modified version.

He had reviewed the changes, and was OK with them.

I have put the series on http://dept-info.labri.fr/~thibault/qemu-ipv6
in the tosubmit branch.

Samuel