Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

[Jan Kiszka]

On 2015-07-29 09:47, Samuel Thibault wrote:
> Jan Kiszka, le Wed 29 Jul 2015 09:39:06 +0200, a écrit :
>> Make sure to add the proper From: of the actual author.
> 
> Ok. Two of the patches are however from a different author, I haven't
> found how to specify different From addresses with git send-email.

This knowledge is buried in scripts here, but IIRC it should suffice
having recorded authorship correctly in git.

> 
>> Also, some are signed-off by you, others not. As a maintainer, you
>> should sign all of them. Or is there a particular reason (not yet
>> reviewed etc.)?
> 
> The reason was just that I hadn't touched those patches at all, but I
> reviewed them all.

If you touch a patch and it's just trivial, add a simple changelog like

Signed-off-by: Author ....
[Samuel: fix minor style issue etc.]
Signed-off-by: You

If you change the patch significantly, rather remove the authors
signed-off and ask to provide it again for the modified version.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux