[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callba
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support |
Date: |
Mon, 18 May 2015 16:35:39 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, May 11, 2015 at 07:04:24PM -0400, John Snow wrote:
> +static void drive_backup_cb(BlkActionState *common)
> +{
> + BlkActionCallbackData *cb_data = common->cb_data;
> + BlockDriverState *bs = cb_data->opaque;
> + DriveBackupState *state = DO_UPCAST(DriveBackupState, common, common);
> +
> + assert(state->bs == bs);
> + if (bs->job) {
> + assert(state->job == bs->job);
> + }
What is the purpose of the if statement?
Why is it not okay for a new job to have started?
> +
> + state->aio_context = bdrv_get_aio_context(bs);
> + aio_context_acquire(state->aio_context);
The bs->job access above should be protected by aio_context_acquire().
pgp2Q3VQrNTHO.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH v4 06/11] block: add refcount to Job object, (continued)
- [Qemu-devel] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 07/11] block: add delayed bitmap successor cleanup, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 08/11] qmp: Add an implementation wrapper for qmp_drive_backup, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 05/11] block: add transactional callbacks feature, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 10/11] iotests: 124 - transactional failure test, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 09/11] block: drive_backup transaction callback support, John Snow, 2015/05/11
- [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations, John Snow, 2015/05/11