qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations
Date: Mon, 18 May 2015 18:22:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 12.05.2015 01:04, John Snow wrote:
From: Kashyap Chamarthy <address@hidden>

Although the canonical source of reference for QMP commands is
qapi-schema.json, for consistency's sake, update qmp-commands.hx to
state the list of supported transactionable operations, namely:

     drive-backup
     blockdev-backup
     blockdev-snapshot-internal-sync
     abort
     block-dirty-bitmap-add
     block-dirty-bitmap-clear

Signed-off-by: Kashyap Chamarthy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
  qmp-commands.hx | 13 ++++++++-----
  1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 7506774..363126a 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1238,11 +1238,14 @@ SQMP
  transaction
  -----------
-Atomically operate on one or more block devices. The only supported operations
-for now are drive-backup, internal and external snapshotting.  A list of
-dictionaries is accepted, that contains the actions to be performed.
-If there is any failure performing any of the operations, all operations
-for the group are abandoned.
+Atomically operate on one or more block devices.  Operations that are
+currently supported: drive-backup, blockdev-backup,
+blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort,
+block-dirty-bitmap-add, block-dirty-bitmap-clear

Hm, seven operations... Worth making it a real list?

Max

(refer to the
+qemu/qapi-schema.json file for minimum required QEMU versions for these
+operations).  A list of dictionaries is accepted, that contains the
+actions to be performed.  If there is any failure performing any of the
+operations, all operations for the group are abandoned.
For external snapshots, the dictionary contains the device, the file to use for
  the new snapshot, and the format.  The default format, if not specified, is




reply via email to

[Prev in Thread] Current Thread [Next in Thread]