[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe contr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table |
Date: |
Tue, 14 Apr 2015 10:30:34 +0100 |
On 14 April 2015 at 02:10, Shannon Zhao <address@hidden> wrote:
> On 2015/4/13 23:58, Alex Bennée wrote:
>>
>> Shannon Zhao <address@hidden> writes:
>>> + UUID = aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657,
>>> 0x7441C03DD766);
>>
>> This looks like a fairly unreadable uuid already. What are these magic
>> numbers?
>>
>
> Yes, this will be modified to use string according to the spec. Like below
> way:
>
> UUID = aml_touuid("33DB4D5B-1FF7-401C-9657-7441C03DD766");
Those are still magic numbers, you've just put them into
a different format. Where do they come from? What do they mean?
-- PMM
- [Qemu-devel] [PATCH v4 02/20] hw/i386/acpi-build: move generic acpi building helpers into dedictated file, (continued)
- [Qemu-devel] [PATCH v4 02/20] hw/i386/acpi-build: move generic acpi building helpers into dedictated file, Shannon Zhao, 2015/04/03
- [Qemu-devel] [PATCH v4 09/20] hw/arm/virt-acpi-build: Generate GTDT table, Shannon Zhao, 2015/04/03
- [Qemu-devel] [PATCH v4 01/20] hw/i386: Move ACPI header definitions in an arch-independent location, Shannon Zhao, 2015/04/03
- [Qemu-devel] [PATCH v4 11/20] hw/arm/virt-acpi-build: Generate RSDP table, Shannon Zhao, 2015/04/03
- [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table, Shannon Zhao, 2015/04/03
[Qemu-devel] [PATCH v4 18/20] hw/acpi/aml-build: Add aml_dword_io() term, Shannon Zhao, 2015/04/03
[Qemu-devel] [PATCH v4 07/20] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers, Shannon Zhao, 2015/04/03
[Qemu-devel] [PATCH v4 20/20] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables, Shannon Zhao, 2015/04/03
[Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table, Shannon Zhao, 2015/04/03