Re: [Qemu-devel] [PATCH v4 18/20] hw/acpi/aml-build: Add aml_dword_io() term

[Alex Bennée]

Shannon Zhao <address@hidden> writes:

> From: Shannon Zhao <address@hidden>
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  hw/acpi/aml-build.c         | 17 +++++++++++++++++
>  include/hw/acpi/aml-build.h |  5 +++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 221d054..2076ba1 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -937,6 +937,23 @@ Aml *aml_word_io(AmlMinFixed min_fixed, AmlMaxFixed 
> max_fixed,
>                              addr_gran, addr_min, addr_max, addr_trans, len,
>                              isa_ranges);
>  }
> +/*
> + * ACPI 1.0b: 6.4.3.5.4 ASL Macros for DWORD Address Descriptor
> + *
> + * More verbose description at:
> + * ACPI 5.0: 19.5.33 DWordIO (DWord IO Resource Descriptor Macro)
> + */
> +Aml *aml_dword_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed,
> +                 AmlDecode dec, AmlISARanges isa_ranges,
> +                 uint32_t addr_gran, uint32_t addr_min,
> +                 uint32_t addr_max, uint32_t addr_trans,
> +                 uint32_t len)
> +
> +{
> +    return aml_dword_as_desc(aml_io_range, min_fixed, max_fixed, dec,
> +                            addr_gran, addr_min, addr_max, addr_trans, len,
> +                            isa_ranges);
> +}
>  
>  /*
>   * ACPI 1.0b: 6.4.3.5.4 ASL Macros for DWORD Address Space Descriptor
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 0d923e8..adefc25 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -188,6 +188,11 @@ Aml *aml_word_io(AmlMinFixed min_fixed, AmlMaxFixed 
> max_fixed,
>                   uint16_t addr_gran, uint16_t addr_min,
>                   uint16_t addr_max, uint16_t addr_trans,
>                   uint16_t len);
> +Aml *aml_dword_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed,
> +                 AmlDecode dec, AmlISARanges isa_ranges,
> +                 uint32_t addr_gran, uint32_t addr_min,
> +                 uint32_t addr_max, uint32_t addr_trans,
> +                 uint32_t len);
>  Aml *aml_dword_memory(AmlDecode dec, AmlMinFixed min_fixed,
>                        AmlMaxFixed max_fixed, AmlCacheble cacheable,
>                        AmlReadAndWrite read_and_write,

-- 
Alex Bennée