Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

[Andreas Färber]

Am 17.03.2015 um 10:08 schrieb Chen Fan:
> ICC bus was invented only to provide hotplug capability to
> CPU and APIC because at the time being hotplug was available only for
> BUS attached devices.
> 
> Now this patch is to drop ICC bus impl, and switch to bus-less
> CPU+APIC hotplug, handling them in the same manner as pc-dimm.
> 
> Signed-off-by: Chen Fan <address@hidden>
> ---
>  hw/i386/pc.c                    | 21 +++++----------------
>  hw/i386/pc_piix.c               |  9 +--------
>  hw/i386/pc_q35.c                |  9 +--------
>  hw/intc/apic.c                  |  6 +++---
>  hw/intc/apic_common.c           | 24 +++++++++++++++++++-----
>  include/hw/i386/apic_internal.h |  5 ++---
>  include/hw/i386/pc.h            |  2 +-
>  target-i386/cpu.c               | 15 ++-------------
>  target-i386/cpu.h               |  2 +-
>  9 files changed, 35 insertions(+), 58 deletions(-)

This mini-series is lacking a cover letter and a change log.
Please also find a better subject for this one: Luckily you are not just
dropping things but rather implementing the new hotplug interface.

Is this a resend from Zhu Guihua's series or did anything change?
I think for Soft Freeze and Hard Freeze coming up today it's too late.

As you may have seen, I've posted a test case to facilitate testing of
the various proposed code movements.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)