[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration |
Date: |
Tue, 17 Mar 2015 10:33:33 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Mar 17, 2015 at 08:36:40AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > - Separate VNC auth scheme is tracked for websockets server,
> > since it makes no sense to try to use VeNCrypt over a TLS
> > enabled websockets connection.
>
> Hmm. That is a problem for the QAPI, the auth scheme is linked to the
> vnc server not the socket.
It seems straightforward enough to just do this:
diff --git a/qapi-schema.json b/qapi-schema.json
index d7c3eec..3362956 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -808,6 +808,7 @@
'clients' : ['VncClientInfo'],
'auth' : 'VncPrimaryAuth',
'*vencrypt' : 'VncVencryptSubAuth',
+ '*ws-auth' : 'VncPrimaryAuth',
'*display' : 'str' } }
And document that 'ws-auth' is used if server->websocket == true
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
[Qemu-devel] [PATCH 2/3] ui: replace printf() calls with VNC_DEBUG, Daniel P. Berrange, 2015/03/16
[Qemu-devel] [PATCH 1/3] ui: remove unused 'wiremode' variable in VncState struct, Daniel P. Berrange, 2015/03/16