[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 29/37] blockdev: Implement eject with basic opera
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 29/37] blockdev: Implement eject with basic operations |
Date: |
Mon, 9 Feb 2015 12:11:29 -0500 |
Implement 'eject' by calling blockdev-open-tray and
blockdev-remove-medium.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
blockdev.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 819a3c1..d4f7b9b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1867,15 +1867,15 @@ out:
void qmp_eject(const char *device, bool has_force, bool force, Error **errp)
{
- BlockBackend *blk;
+ Error *local_err = NULL;
- blk = blk_by_name(device);
- if (!blk) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, device);
+ qmp_blockdev_open_tray(device, has_force, force, &local_err);
+ if (local_err) {
+ error_propagate(errp, local_err);
return;
}
- eject_device(blk, force, errp);
+ qmp_blockdev_remove_medium(device, errp);
}
void qmp_block_passwd(bool has_device, const char *device,
--
2.1.0
- Re: [Qemu-devel] [PATCH v2 32/37] qmp: Introduce blockdev-change-medium, (continued)
- [Qemu-devel] [PATCH v2 35/37] hmp: Add read-only-mode option to change command, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 37/37] iotests: Add test for change-related QMP commands, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 23/37] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 30/37] blockdev: Implement change with basic operations, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 29/37] blockdev: Implement eject with basic operations,
Max Reitz <=
- [Qemu-devel] [PATCH v2 20/37] block: Prepare for NULL BDS, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 26/37] blockdev: Add blockdev-close-tray, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 25/37] blockdev: Add blockdev-open-tray, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 12/37] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/02/09